flare
Well-known member
Last edited by a moderator:
v0.10.16 - Onyx v2
- Thread starter eduffield
- Start date
crowning
Well-known member
That's excactly what will happen now :grin:
EDIT:
He's gonna hate me
I hereby officially deny having made above post, and the proposal to add him to the development team as well.
My account was hacked.
Wasn't me...
REALLY!
crowning
Well-known member
eduffield , what about a quick fix here to get rid of those duplicate entries? https://github.com/darkcoin/darkcoin/blob/master/src/masternode.cpp#L140:
Code:
if(tx.AcceptableInputs(state, true)){
LogPrintf("dsee - Accepted masternode entry %i %i\n", count, current);
if(GetInputAge(vin) < MASTERNODE_MIN_CONFIRMATIONS){
LogPrintf("dsee - Input must have least %d confirmations\n", MASTERNODE_MIN_CONFIRMATIONS);
pfrom->Misbehaving(20);
return;
}
addrman.Add(CAddress(addr), pfrom->addr, 2*60*60);
// Fix start
BOOST_FOREACH(CMasterNode& mn, darkSendMasterNodes) {
if(mn.addr == addr){
LogPrintf("Duplicate master node entry - rejected %s \n", mn.addr.ToString().c_str());
return;
}
}
// Fix end
Last edited by a moderator:
flare
Well-known member
This needs a protocolversion change, otherwise we'll get into trouble...
Oh yeah!! Congrats man! :wink:
Hey, you might be next on the list for an offer you can't refuse... :grin:He's gonna hate me
I hereby officially deny having made above post, and the proposal to add him to the development team as well.
My account was hacked.
Wasn't me...
REALLY!
TsuyokuNaritai
Active member
Does using it trigger a warning to the user/operator? Anything like this should cause a big impossible-to-miss equivalent of hands coming out of the screen to shake you awake and make sure you know what you're doing because you're stepping off the path and into the scary dark forest to get lost and eaten by wolves.
Last edited by a moderator:
flare
Well-known member
You are right, there should be a warning IN CAPITAL LETTERS...
oblox
Well-known member
lol, it was flipped Friday or Saturday.
it was, but then switched off during the weekend right? Maybe I missed the notice it was back on
All good.
Scriptiee
Member
Don't use features you don't know about/havent seen documentation and you'll be grand... aimed at you as well camosoul
As always a relevant http://xkcd.com/293/
eduffield
Core Developer
Making the code only accept unique masternodes is really easy, but it's also exploitable. For example, what if you started a masternode with someone else's address during a protocol change. That would allow you to register and they wouldn't be able to after that. There's really no way to prove you own that ip address beyond my proof-of-service concept.
One of the next versions of the protocol will start to encrypt all messages sent to and from masternodes using their masternodeprivkeys, this means if you don't control that IP, it won't be able to talk to anyone on the network. After that, proof-of-service will kick in and start banning those nodes.
crowning
Well-known member
Quick idea (right now I'm at work and can't test this):
When the bad node registers let the other nodes ask THAT IP-address for the corresponding vin (or pubkey or whatever else is easy to access).
- it's a honest node -> it will give you the correct answer
- it's the bad node -> the 'good' node (which owns the physical address) is connected (we don't talk about IP-spoofing here, don't we?) and gives you the wrong answer (it can't return the bad node's vin/pubkey/etc. because it has no idea what's going on).
oblox
Well-known member
Mine sat about 18 hours with no activity with one remaining 500 denomination. I'm now moving along, but still not finished compared to my 10s, and 1s.
oblox
Well-known member
Seems like a logical approach... there would be no other way for the fake node to get the key generated from the masternode genkey command unless you were the one generating it (or logged their computer).
But couldn't you use a legit masternode to grab the genkeys from other nodes (from the check) and then use those same keys to claim ownership for future 1000 coin vins? Doesn't that put you back at square one?
Same here :-(
8 hrs running .16.15 and still sitting at 1% (which I think really means 0%, since that what it started at).
JGCMiner
Active member
Yeah. It is especially odd since the older v12 worked fine except for the high fees. Not sure what is going on.
Anyway will run overnight to see if it mixes.
oblox
Well-known member
Look at your coin control. Are your coins put into denomations in powers of 2 (1024, 512, 256, 128, 64, 32, 16, 8, 4, 2)? If so, you'll want to select all and send to a fresh address in the wallet. Not sure why it is doing that but it would never start when the coins were broken up like that.
Any idea on why this happens eduffield ? It has happened on multiple occasions for me.