v0.10.12.x RC4 Testing

eduffield · Aug 2, 2014

yidakee said:
Then what heck happened? wrong send address? I though I had read it didnt show up on the explorer at all...

I'm still waiting on the debug.log from that user. It looks like their client submitted an empty output for 8000 with no pubkey, then signed it. Although, there's a lot of weird stuff with that transaction. The transaction is for 8000DRK, which doesn't make any sense. Darksend is limited to 2 users at 1000DRK per user. So each Darksend is limited to 2000DRK.

EDIT: Definitely not a transaction created with Darksend. Darksend can't pay fees other than 0.001DRK, and this transaction pays 0.014DRK

yidakee · Aug 2, 2014

eduffield said:
I'm still waiting on the debug.log from that user. It looks like their client submitted an empty output for 8000 with no pubkey, then signed it. Although, there's a lot of weird stuff with that transaction. The transaction is for 8000DRK, which doesn't make any sense. Darksend is limited to 2 users at 1000DRK per user. So each Darksend is limited to 2000DRK.

EDIT: Definitely not a transaction created with Darksend. Darksend can't pay fees other than 0.001DRK, and this transaction pays 0.014DRK

Tried to replicate. Sent 8k to Dark Sailor. When clicking send this showed up

Clicking yes, first said "waiting", then it broadcasted it and it changed to this...

Instantly got a -0.025

Status: 0/unconfirmed, broadcast through 9 nodes
Date: 8/2/14 09:03
To: Dark Sailor moRLXEivgJd9q84DJgLYtn6Z5DjjQswZDK
Debit: -8000.00 DRK
Transaction fee: -0.008 DRK
Net amount: -8000.008 DRK
Transaction ID: c9f2f5a38f05c698f26b15c9d72b1b163fdc4827d5e521f72e1a2a7725c917c1

Debug information

Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -1.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -100.00000001 DRK
Debit: -500.00000001 DRK
Debit: -100.00000001 DRK
Credit: 0.99200053 DRK

Ok, Evan, I'm really not getting this denomination fee. I just got charged .008 for an 8k tx... that is perfectly acceptable! But then start getting charged again 0.01 to denominate my change, when it was already denominated to start with... it really looks as if D+ is a credit muncher.

This just came in after first confirm on the tx

Status: 0/unconfirmed, broadcast through 8 nodes
Date: 8/2/14 09:09
Debit: 0.00 DRK
Credit: 0.00 DRK
Transaction fee: -0.001 DRK
Net amount: -0.001 DRK
Transaction ID: 9379948936d28fc6910b7ee3ddaee6fd5bd3f0defa7c7dd5ba3dba50ad1d6ef1

Debug information

Debit: -0.99200053 DRK
Debit: -0.33779638 DRK
Credit: 0.2734001 DRK
Credit: 0.05468002 DRK
Credit: 0.10 DRK
Credit: 0.2734001 DRK
Credit: 0.05468002 DRK
Credit: 0.10 DRK
Credit: 0.2734001 DRK
Credit: 0.04455655 DRK
Credit: 0.05468002 DRK
Credit: 0.10 DRK

Transaction:
CTransaction(hash=9379948936d28fc6910b7ee3ddaee6fd5bd3f0defa7c7dd5ba3dba50ad1d6ef1, ver=1, vin.size=2, vout.size=10, nLockTime=0)
CTxIn(COutPoint(c9f2f5a38f05c698f26b15c9d72b1b163fdc4827d5e521f72e1a2a7725c917c1, 1), scriptSig=3045022071529117eb5083bb)
CTxIn(COutPoint(676b742902d67d07aa8eb12ab21cb9f27f8a0d5a38d93beac4cd6ed203b92d13, 3), scriptSig=30440220448164f4d997686e)
CTxOut(nValue=0.27340010, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.05468002, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.10000000, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.27340010, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.05468002, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.10000000, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.27340010, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.04455655, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.05468002, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)
CTxOut(nValue=0.10000000, scriptPubKey=OP_DUP OP_HASH160 4f782913ca73)

Inputs:
mg8cLTHXPiuRabfUA18wD3F69dEHqHGeJU Amount=0.99200053 DRK IsMine=true
musoZJBjc6ErDqpyoPodQUVAtz8ypV9C27 Amount=0.33779638 DRK IsMine=true

flare · Aug 2, 2014

yidakee said:
Tried to replicate. Sent 8k to Dark Sailor. When clicking send this showed up

Clicking yes, first said "waiting", then it broadcasted it and it changed to this...

Instantly got a -0.025

Ok, Evan, I'm really not getting this denomination fee. I just got charged .008 for an 8k tx... that is perfectly acceptable! But then start getting charged again 0.01 to denominate my change, when it was already denominated to start with... it really looks as D+ is a credit muncher.

This just came in after first confirm on the tx

The tx got transferred http://test.explorer.darkcoin.fr/tx/c9f2f5a38f05c698f26b15c9d72b1b163fdc4827d5e521f72e1a2a7725c917c1

dark-sailor · Aug 2, 2014

flare said:
The tx got transferred http://test.explorer.darkcoin.fr/tx/c9f2f5a38f05c698f26b15c9d72b1b163fdc4827d5e521f72e1a2a7725c917c1

Received the 8000 drk

Status: 2/unconfirmed
Date: 02/08/2014 17:03
From: unknown
To: moRLXEivgJd9q84DJgLYtn6Z5DjjQswZDK (own address)
Credit: 8000.00 DRK
Net amount: +8000.00 DRK
Transaction ID: c9f2f5a38f05c698f26b15c9d72b1b163fdc4827d5e521f72e1a2a7725c917c1

yidakee · Aug 2, 2014

Collateral bug hitting again...

vertoe · Aug 2, 2014

yidakee said:
Collateral bug hitting again...

Yes, happens to me too.

yidakee · Aug 2, 2014

I cannot discard bad internet connection. My bloody ISP has not come yet to swap my router and check connection. Every so often it hick-ups and stops working for 1 or 2 minutes. Could be that

chaeplin · Aug 2, 2014

flare said:
Hmm, seems to be a bug - the resulting txo is invalid, as the adress does not decode and the ScriptPubKey is empty.

Please send the wallet and testnet3 folder to [email protected] so eduffield can have a look at this.

View attachment 265

It has nonstandard type.

Code:

   "vout" : [
        {
            "value" : 8000.00000000,
            "n" : 0,
            "scriptPubKey" : {
                "asm" : "",
                "hex" : "",
                "type" : "nonstandard"
            }
        },
        {
            "value" : 0.98600090,
            "n" : 1,
            "scriptPubKey" : {
                "asm" : "OP_DUP OP_HASH160 6d69ee6ce9e61e78ffdebba6e32a545c40218288 OP_EQUALVERIFY OP_CHECKSIG",
                "hex" : "76a9146d69ee6ce9e61e78ffdebba6e32a545c4021828888ac",
                "reqSigs" : 1,
                "type" : "pubkeyhash",
                "addresses" : [
                    "mqVUrCiDxJYdzCmtnujMwyWaGGTnfoDmAs"
                ]
            }
        }
    ],
    "blockhash" : "000000067a199971b6d52c864e0080c0609b5f8aa25e43cd9eea3588965aa6fe",
    "confirmations" : 482,
    "time" : 1406924364,
    "blocktime" : 1406924364
}

blocks found by p2pool have nonstandard.

Code:

       {
            "value" : 0.00000000,
            "n" : 4,
            "scriptPubKey" : {
                "asm" : "OP_RETURN 606651bfd4eaaf581efa0f0073599a29ea0805976e0203ca9dfdc4795c9386eb0000000000000000",
                "hex" : "6a28606651bfd4eaaf581efa0f0073599a29ea0805976e0203ca9dfdc4795c9386eb0000000000000000",
                "type" : "nonstandard"
            }
        }

http://test.explorer.darkcoin.qa/tx/6e5c7bc6feff2488b199642f351e4710e39c5011fb6df3be8a74c834a463b4b2

flare · Aug 2, 2014

chaeplin said:

It has nonstandard type.

Code:

   "vout" : [
        {
            "value" : 8000.00000000,
            "n" : 0,
            "scriptPubKey" : {
                "asm" : "",
                "hex" : "",
                "type" : "nonstandard"
            }
        },
        {
            "value" : 0.98600090,
            "n" : 1,
            "scriptPubKey" : {
                "asm" : "OP_DUP OP_HASH160 6d69ee6ce9e61e78ffdebba6e32a545c40218288 OP_EQUALVERIFY OP_CHECKSIG",
                "hex" : "76a9146d69ee6ce9e61e78ffdebba6e32a545c4021828888ac",
                "reqSigs" : 1,
                "type" : "pubkeyhash",
                "addresses" : [
                    "mqVUrCiDxJYdzCmtnujMwyWaGGTnfoDmAs"
                ]
            }
        }
    ],
    "blockhash" : "000000067a199971b6d52c864e0080c0609b5f8aa25e43cd9eea3588965aa6fe",
    "confirmations" : 482,
    "time" : 1406924364,
    "blocktime" : 1406924364
}

blocks found by p2pool have nonstandard.

Code:

       {
            "value" : 0.00000000,
            "n" : 4,
            "scriptPubKey" : {
                "asm" : "OP_RETURN 606651bfd4eaaf581efa0f0073599a29ea0805976e0203ca9dfdc4795c9386eb0000000000000000",
                "hex" : "6a28606651bfd4eaaf581efa0f0073599a29ea0805976e0203ca9dfdc4795c9386eb0000000000000000",
                "type" : "nonstandard"
            }
        }

http://test.explorer.darkcoin.qa/tx/6e5c7bc6feff2488b199642f351e4710e39c5011fb6df3be8a74c834a463b4b2

Yes, eduffield is currently looking at this - seems like litecoin client is able to produce invalid pubScripts in rare occasions

yidakee · Aug 2, 2014

flare said:
Yes, eduffield is currently looking at this - seems like litecoin client is able to produce invalid pubScripts in rare occasions

But isn't DRK fundamentally a bitcoin fork ? I'm a bit confused about this one as DRK uses the same API as BTC

eduffield · Aug 2, 2014

flare said:
Yes, eduffield is currently looking at this - seems like litecoin client is able to produce invalid pubScripts in rare occasions

To stop this from ever happening again I've added a client-wide check to make sure all outputs are standard and canonical (with a value of over 0, because p2pool uses non-standard transactions). It's odd the client will allow you to destroy money, so I've removed that ability.

Code:

bool CWallet::CreateTransaction(std::vector<pair<CScript, int64> >& vecSend,
                                CWalletTx& wtxNew, CReserveKey& reservekey, int64& nFeeRet, std::string& strFailReason, const CCoinControl* coinControl, AvailableCoinsType coin_type)
{
    int64 nValue = 0;
    BOOST_FOREACH (PAIRTYPE(CScript, int64)& s, vecSend)
    {
        if(s.second > 0){
            if(!IsStandard(s.first) || !IsCanonicalPubKey(s.first)){
                strFailReason = _("Transaction must contain a standard pubScript");
                return false;
            }
        }

        BOOST_FOREACH(int64 d, darkSendDenominations)
            if(s.second == d)
                s.second -= 1; //denominations are reserved, subtract 1 satoshi (10.00000001 will become 10DRK)

        if (nValue < 0)
        {
            strFailReason = _("Transaction amounts must be positive");
            return false;
        }
        nValue += s.second;
    }
    if (vecSend.empty() || nValue < 0)
    {
        strFailReason = _("Transaction amounts must be positive");
        return false;
    }

vertoe · Aug 2, 2014

yidakee said:
But isn't DRK fundamentally a bitcoin fork ? I'm a bit confused about this one as DRK uses the same API as BTC

Its a litecoin fork which is a bitcoin fork

And cool, we discovered a Litecoin bug

Should we file a ticket?

chaeplin · Aug 2, 2014

flare said:
Yes, eduffield is currently looking at this - seems like litecoin client is able to produce invalid pubScripts in rare occasions

Bitcoin has.

Bitcoin p2pool block.
http://blockexplorer.com/tx/28c8c18347ac30ef2230479a1685f49aecedebd3e38517714b19034f7de9f857

nj47 · Aug 2, 2014

eduffield said:

To stop this from ever happening again I've added a client-wide check to make sure all outputs are standard and canonical (with a value of over 0, because p2pool uses non-standard transactions). It's odd the client will allow you to destroy money, so I've removed that ability.

Code:

bool CWallet::CreateTransaction(std::vector<pair<CScript, int64> >& vecSend,
                                CWalletTx& wtxNew, CReserveKey& reservekey, int64& nFeeRet, std::string& strFailReason, const CCoinControl* coinControl, AvailableCoinsType coin_type)
{
    int64 nValue = 0;
    BOOST_FOREACH (PAIRTYPE(CScript, int64)& s, vecSend)
    {
        if(s.second > 0){
            if(!IsStandard(s.first) || !IsCanonicalPubKey(s.first)){
                strFailReason = _("Transaction must contain a standard pubScript");
                return false;
            }
        }

        BOOST_FOREACH(int64 d, darkSendDenominations)
            if(s.second == d)
                s.second -= 1; //denominations are reserved, subtract 1 satoshi (10.00000001 will become 10DRK)

        if (nValue < 0)
        {
            strFailReason = _("Transaction amounts must be positive");
            return false;
        }
        nValue += s.second;
    }
    if (vecSend.empty() || nValue < 0)
    {
        strFailReason = _("Transaction amounts must be positive");
        return false;
    }

Just to confirm, that change is only implemented for transactions built in the standard wallet, but it is still possible to broadcast a non-standard transaction (P2SH for example) that you created externally?

defunctec · Aug 2, 2014

nj47 said:
Just to confirm, that change is only implemented for transactions built in the standard wallet, but it is still possible to broadcast a non-standard transaction (P2SH for example) that you created externally?

Sorry everyone, i had to go out for a few hours...
The 8000 coins where not darksent, i went into console and typed darksend auto 8000, and the client allowed it.

I'm trying to figure out how to send Evan the files, gmail is saying the email is to large. I 7ziped the wallet.dat and testnet3... any advice?

canibalbranco · Aug 2, 2014

[QUOTE = "chaeplin, POS: 14268, Membro: 206"] Bitcoin tem.

Bloco p2pool Bitcoin.
http://blockexplorer.com/tx/28c8c18347ac30ef2230479a1685f49aecedebd3e38517714b19034f7de9f857 [/ QUOTE]

Ok Mr. Evan , it's time to fix the work of Satoshi Nakamoto!

chaeplin · Aug 2, 2014

I have found this. I just understand part of.
http://www.quantabytes.com/articles/a-survey-of-bitcoin-transaction-types
https://bitcointalk.org/index.php?topic=130392.msg1396635#msg1396635
https://bitcointalk.org/index.php?topic=130392.msg1396722#msg1396722

elbereth · Aug 2, 2014

defunctec said:
I'm trying to figure out how to send Evan the files, gmail is saying the email is to large. I 7ziped the wallet.dat and testnet3... any advice?

Use dropbox or any other tool allowing you to upload big files then send the link to evan.

chaeplin · Aug 2, 2014

defunctec said:
Sorry everyone, i had to go out for a few hours...
The 8000 coins where not darksent, i went into console and typed darksend auto 8000, and the client allowed it.

I'm trying to figure out how to send Evan the files, gmail is saying the email is to large. I 7ziped the wallet.dat and testnet3... any advice?

Use google drive.
Drop him shared link.

eduffield · Aug 2, 2014

nj47 said:
Just to confirm, that change is only implemented for transactions built in the standard wallet, but it is still possible to broadcast a non-standard transaction (P2SH for example) that you created externally?

Correct

v0.10.12.x RC4 Testing

Core Developer

Well-known member

Well-known member

Member

Well-known member

Three of Nine

Well-known member

Well-known member

Well-known member

Well-known member

Core Developer

Three of Nine

Well-known member

nj47

Guest

Active member

Member

Well-known member

Well-known member

Well-known member

Core Developer