*** Please update to 10.9.3 or 9.5.3 ***
I think I've fixed all of our masternode voting problems and 1/2 of the ghost masternode problem. I'll fix the other half tomorrow.
Hi Evan,
good work, works much better for me so far. Nevertheless i have found something which either is a bug in the abe blockexplorer or in the algorithm how the clients store the votes in the blockchain.
If you look at the blocks
14214+ since the payout started you will notice the following:
Block
14214
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 1
Block
14215
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 2
14215 nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE 1
Block
14216
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 2
14215 nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE 2
14216 QSp8gRBSez2Y6MQCgGSiMsoKxnsa9HVVk 1
Block
14217
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 2
14215 nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE 3
14216 QSp8gRBSez2Y6MQCgGSiMsoKxnsa9HVVk 2
14217 Z92SLSwb3z2D47g47Y1E9LczimJiVFtvv 1
Block
14218
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 3
14215 nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE 4
14216 QSp8gRBSez2Y6MQCgGSiMsoKxnsa9HVVk 3
14217 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 1
14218 XomhG7xJcL5iSCQhM4AcS8N381DguAobA 1
So far, so good - each block is appending a vote to the existing votes. But
nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE is receiving votes in each block, too!?
And with the next block the oddness continues
Block
14219
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 3
14216 QSp8gRBSez2Y6MQCgGSiMsoKxnsa9HVVk 4
14217 Z92SLSwb3z2D47g47Y1E9LczimJiVFtvv 1
14218 fqgi8JuLcrrnhkw1JnoCFNqV7qPQSQ85f 1
14219 kSoDShs3inDHZjMBVbLLF4n1YXKMFd8sR 1
Obviously nyua6yT2XjttboGdjLdNMWZqSmrtqHeUE got another vote, and since you lowered MASTERNODE_PAYMENTS_MIN_VOTES to 5 in
main.h it got paid out. But additionally the vote for 14218 changed from XomhG7xJcL5iSCQhM4AcS8N381DguAobA to fqgi8JuLcrrnhkw1JnoCFNqV7qPQSQ85f to be changed back to XomhG7xJcL5iSCQhM4AcS8N381DguAobA in the next block - odd!?
Block
14220
Code:
Blockheight Pubkey Votes
14214 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 4
14217 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 1
14218 XomhG7xJcL5iSCQhM4AcS8N381DguAobA 1
14219 kSoDShs3inDHZjMBVbLLF4n1YXKMFd8sR 2
14220 YvNsM5mxwbSjM6q2MHifymuTZDjaueE1B 1
And here things get messy: Vote counts for 14214 and 14217 and now inconsistently lowered from 4 to 1.
The next block is odd too:
Block
14221
Code:
Blockheight Pubkey Votes
14217 fgAKRZmRDp53yEPegeBGu3bKmH2pYjM4o 2
14218 XomhG7xJcL5iSCQhM4AcS8N381DguAobA 2
14219 kSoDShs3inDHZjMBVbLLF4n1YXKMFd8sR 3
14220 YvNsM5mxwbSjM6q2MHifymuTZDjaueE1B 2
14221 dFYvfCtehekxuocBrKewSCNYgg1a5RCtw 1
Vote count for 14217 now changed to 2 (+1), 14218 changed to 2 (+1), 14219 changed to 3 (+1), 14220 changed to 2 (+1) - which would mean this block counted for at least 5 votes?!
So either the abe-explorer is misinterpreting the votes from the blockchain, or the votes are not stored consistently in the blockchain. Can you please dig into this? Thanks!
Holger
EDIT: Seems something is broken with the vote system, votes are stacking up in the same scheme since
14256+ now - which is impossible.
Code:
Blockheight Pubkey Votes
142** ??? 5
142** ??? 4
142** ??? 3
142** ??? 2
142** ??? 1
EDIT2:
Verified by 'masternode votes' and 'getblocktemplate', vote system is not counting correctly.
Code:
./darkcoind masternode votes
{
"14298" : "OP_DUP OP_HASH160 1fed77f7969136e1a4f59b53b34a98c2f6d9a2d6 OP_EQUALVERIFY OP_CHECKSIG",
"14299" : "OP_DUP OP_HASH160 bce5f22f341d49544ff398a071aac7dfa3bacc4b OP_EQUALVERIFY OP_CHECKSIG",
"14300" : "OP_DUP OP_HASH160 d8d3cef6e63fa5104f75e2e42a26d69ad9b13dff OP_EQUALVERIFY OP_CHECKSIG",
"14301" : "OP_DUP OP_HASH160 d3d18906c77e680fb90d8dd0298fdc267d7fecaa OP_EQUALVERIFY OP_CHECKSIG",
"14302" : "OP_DUP OP_HASH160 5e2a44becdc000fa5331ac7e6f0512d7defe31fe OP_EQUALVERIFY OP_CHECKSIG",
"14303" : "OP_DUP OP_HASH160 bce5f22f341d49544ff398a071aac7dfa3bacc4b OP_EQUALVERIFY OP_CHECKSIG",
"14304" : "OP_DUP OP_HASH160 cc9d15a2c7682233f85a8cff39ca1f152221ef3c OP_EQUALVERIFY OP_CHECKSIG",
"14305" : "OP_DUP OP_HASH160 f860d685867e1f1768bdc22bbcacf7a2a9ee2c31 OP_EQUALVERIFY OP_CHECKSIG",
"14306" : "OP_DUP OP_HASH160 81e9482117114c4d9fbe0d2851b663931a58d0cd OP_EQUALVERIFY OP_CHECKSIG",
"14307" : "OP_DUP OP_HASH160 81e9482117114c4d9fbe0d2851b663931a58d0cd OP_EQUALVERIFY OP_CHECKSIG"
}
./darkcoind getblocktemplate
[...]
"votes" : [
"df370000000000001976a914bce5f22f341d49544ff398a071aac7dfa3bacc4b88ac05000000",
"e0370000000000001976a914cc9d15a2c7682233f85a8cff39ca1f152221ef3c88ac04000000",
"e1370000000000001976a914f860d685867e1f1768bdc22bbcacf7a2a9ee2c3188ac03000000",
"e2370000000000001976a91481e9482117114c4d9fbe0d2851b663931a58d0cd88ac02000000",
"e3370000000000001976a91481e9482117114c4d9fbe0d2851b663931a58d0cd88ac01000000"
],
"payee" : "mp6rSxNV1gtSB2KMFDLMkEK6pcFQgEGfXC",
"masternode_payments" : true
}
[...]
Last two lines should read
Code:
"e237 0000000000001976a914 81e9482117114c4d9fbe0d2851b663931a58d0cd88ac _01_ 000000",
"e337 0000000000001976a914 81e9482117114c4d9fbe0d2851b663931a58d0cd88ac _02_ 000000"
after receiving two votes for 81e9482...
