demo
Well-known member
And by the way, it is shocking that not even the core members (like @UdjinM6 ) have clear view of what the specifications are.
And by the way, it is shocking that not even the core members (like @UdjinM6 ) have clear view of what the specifications are.
A discussion between two developers about c++ specification and what would be 'the best approach' to apply those is shocking to you ? Or did I miss what you meant by "The Specifications" ....
tgflynn said:The question of these non-standard signals is currently very unclear to me.
The C++ specifications refer to the implementation of the design to the language c++. The c++ language specifications do not require necessarily the deep understanding of the design.UdjinM6 said:Other signals are not clear for me too tbh The point was defining max value via one of enum members and not by some magic number which imo is a better/cleaner way.
As to him not knowing about other signals, It does not surprise me that a developer reviewing one section of code is not sure about other parts (signals) that are not related to the section he is reviewing. As long as he knows the part he is responsible for and thus reviewing there is no problem there.
// SIGNAL VARIOUS THINGS TO HAPPEN:
enum vote_signal_enum_t {
VOTE_SIGNAL_NONE = 0,
VOTE_SIGNAL_FUNDING = 1, // -- fund this object for it's stated amount
VOTE_SIGNAL_VALID = 2, // -- this object checks out in sentinel engine
VOTE_SIGNAL_DELETE = 3, // -- this object should be deleted from memory entirely
VOTE_SIGNAL_ENDORSED = 4, // -- officially endorsed by the network somehow (delegation)
VOTE_SIGNAL_NOOP1 = 5, // FOR FURTHER EXPANSION
VOTE_SIGNAL_NOOP2 = 6,
VOTE_SIGNAL_NOOP3 = 7,
VOTE_SIGNAL_NOOP4 = 8,
VOTE_SIGNAL_NOOP5 = 9,
VOTE_SIGNAL_NOOP6 = 10,
VOTE_SIGNAL_NOOP7 = 11,
VOTE_SIGNAL_NOOP8 = 12,
VOTE_SIGNAL_NOOP9 = 13,
VOTE_SIGNAL_NOOP10 = 14,
VOTE_SIGNAL_NOOP11 = 15,
VOTE_SIGNAL_CUSTOM1 = 16, // SENTINEL CUSTOM ACTIONS
VOTE_SIGNAL_CUSTOM2 = 17, // 16-35
VOTE_SIGNAL_CUSTOM3 = 18,
VOTE_SIGNAL_CUSTOM4 = 19,
VOTE_SIGNAL_CUSTOM5 = 20,
VOTE_SIGNAL_CUSTOM6 = 21,
VOTE_SIGNAL_CUSTOM7 = 22,
VOTE_SIGNAL_CUSTOM8 = 23,
VOTE_SIGNAL_CUSTOM9 = 24,
VOTE_SIGNAL_CUSTOM10 = 25,
VOTE_SIGNAL_CUSTOM11 = 26,
VOTE_SIGNAL_CUSTOM12 = 27,
VOTE_SIGNAL_CUSTOM13 = 28,
VOTE_SIGNAL_CUSTOM14 = 29,
VOTE_SIGNAL_CUSTOM15 = 30,
VOTE_SIGNAL_CUSTOM16 = 31,
VOTE_SIGNAL_CUSTOM17 = 32,
VOTE_SIGNAL_CUSTOM18 = 33,
VOTE_SIGNAL_CUSTOM19 = 34,
VOTE_SIGNAL_CUSTOM20 = 35
};
When the developers talked about signals, this is what signals they meant.
https://github.com/dashpay/dash/blob/v0.12.1.x/src/governance-vote.h
Code:// SIGNAL VARIOUS THINGS TO HAPPEN: enum vote_signal_enum_t { VOTE_SIGNAL_NONE = 0, VOTE_SIGNAL_FUNDING = 1, // -- fund this object for it's stated amount VOTE_SIGNAL_VALID = 2, // -- this object checks out in sentinel engine VOTE_SIGNAL_DELETE = 3, // -- this object should be deleted from memory entirely VOTE_SIGNAL_ENDORSED = 4, // -- officially endorsed by the network somehow (delegation) VOTE_SIGNAL_NOOP1 = 5, // FOR FURTHER EXPANSION VOTE_SIGNAL_NOOP2 = 6, VOTE_SIGNAL_NOOP3 = 7, VOTE_SIGNAL_NOOP4 = 8, VOTE_SIGNAL_NOOP5 = 9, VOTE_SIGNAL_NOOP6 = 10, VOTE_SIGNAL_NOOP7 = 11, VOTE_SIGNAL_NOOP8 = 12, VOTE_SIGNAL_NOOP9 = 13, VOTE_SIGNAL_NOOP10 = 14, VOTE_SIGNAL_NOOP11 = 15, VOTE_SIGNAL_CUSTOM1 = 16, // SENTINEL CUSTOM ACTIONS VOTE_SIGNAL_CUSTOM2 = 17, // 16-35 VOTE_SIGNAL_CUSTOM3 = 18, VOTE_SIGNAL_CUSTOM4 = 19, VOTE_SIGNAL_CUSTOM5 = 20, VOTE_SIGNAL_CUSTOM6 = 21, VOTE_SIGNAL_CUSTOM7 = 22, VOTE_SIGNAL_CUSTOM8 = 23, VOTE_SIGNAL_CUSTOM9 = 24, VOTE_SIGNAL_CUSTOM10 = 25, VOTE_SIGNAL_CUSTOM11 = 26, VOTE_SIGNAL_CUSTOM12 = 27, VOTE_SIGNAL_CUSTOM13 = 28, VOTE_SIGNAL_CUSTOM14 = 29, VOTE_SIGNAL_CUSTOM15 = 30, VOTE_SIGNAL_CUSTOM16 = 31, VOTE_SIGNAL_CUSTOM17 = 32, VOTE_SIGNAL_CUSTOM18 = 33, VOTE_SIGNAL_CUSTOM19 = 34, VOTE_SIGNAL_CUSTOM20 = 35 };
The problem is ethical. Building a wall without knowing whether the wall is a wall of a school or a wall of a prison, this is what bothers me. I respect the employees who are trying to understand the big picture and who are trying to know and to understand how their small actions are used by their employers and for what purpose. This attitude differentiates the free persons from the slaves.
The fact that @UdjinM6 is trying to understand the big picture is positive for him, the fact that he cannot understand it is shocking. If he cannot understand what the above signals are, then who can?
Speaking of these "custom numbers" specifically - they are smth reserved for the future use, like unused op_code's in bitcoin.
It is important to note that the proposal is not stored in the blockchain; in fact, neither proposals nor votes are stored in the blockchain. The proposal ballots are only stored in the internal pools of each node. The nodes periodically synchronize these pools between each other.
....
Again, it is important to note that a vote is stored only in the internal storage. It is not stored in the blockchain.